Page MenuHomePhabricator
Differential D18872

Add std::optional support to Boost's equality check
ClosedPublic
Actions

Authored by PiRK on Wed, Nov 5, 12:29.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC3fb2ed2ceb27: Add std::optional support to Boost's equality check
Summary

Also moved the operators to the bottom of the file since they're less important and to group them together.

Co-authored-by: Hodlinator <172445034+hodlinator@users.noreply.github.com>
Co-authored-by: stickies-v <stickies-v@protonmail.com>

This is a partial backport of core#30618
https://github.com/bitcoin/bitcoin/pull/30618/commits/743ac30e349e181c26a2d2af0bcb93b0835ce521

This allows addressing some TODOs in coins_tests.cpp (which turned out needed a bit more than just switching to c++20)

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Wed, Nov 5, 12:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 5, 12:29
PiRK requested review of this revision.Wed, Nov 5, 12:29
teamcity edited the summary of this revision. (Show Details)Wed, Nov 5, 12:29
PiRK added inline comments.Wed, Nov 5, 12:31
src/test/coins_tests.cpp
622–625 ↗(On Diff #56424)

not related, but the change is trivial enough to avoid a separate diff for this imo

Harbormaster completed remote builds in B34954: Diff 56424.Wed, Nov 5, 12:52
Fabien accepted this revision.Wed, Nov 5, 16:29
This revision is now accepted and ready to land.Wed, Nov 5, 16:29
Closed by commit rABC3fb2ed2ceb27: Add std::optional support to Boost's equality check (authored by Lőrinc <pap.lorinc@gmail.com>, committed by PiRK). · Explain WhyWed, Nov 5, 19:37
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC3fb2ed2ceb27: Add std::optional support to Boost's equality check.

Revision Contents
Changeset List

PathSize
src/
test/
18 lines
util/
30 lines
36 lines

Diff 56463

View Options

src/test/coins_tests.cpp

Loading...
View Options

src/test/util/setup_common.h

Loading...
View Options

src/test/util/setup_common.cpp

Loading...