Page MenuHomePhabricator

[lint] enable FLY002 checks for the Electrum codebase
ClosedPublic

Authored by PiRK on Mon, Nov 10, 15:52.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC32f7e38bb1ab: [lint] enable FLY002 checks for the Electrum codebase
Summary

Checks for str.join calls that can be replaced with f-strings for better readability.

This check is easy to enable, so let's do it immediately to reduce the style divergence between electrum and the rest of the codebase.
The other two (convert % format and .format into f-strings) are a bit more tedious and will be done in multiple chunks

Test Plan
arc lint --everything
ninja check-electrum check-electrum-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK requested review of this revision.Mon, Nov 10, 15:52
Fabien added a subscriber: Fabien.
Fabien added inline comments.
electrum/electrumabc/exchange_rate.py
78 ↗(On Diff #56554)

Out of scope but it would be safer to use the URL constructor to get proper url encoding

This revision is now accepted and ready to land.Mon, Nov 10, 20:43