Paths

Table of Contentst

Differential D18918

[ecash-lib] Export new constants and interfaces to be used for chained txs in ecash-wallet
ClosedPublic
Actions

Authored by bytesofman on Mon, Nov 10, 17:32.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC43d39e207b44: [ecash-lib] Export new constants and interfaces to be used for chained txs in…

Summary

Isolate the ecash-lib changes needed for ecash-wallet chained txs in this diff. In this way, we can ensure they are published and available for ecash-wallet to pull in as a dep.

The changes to action.ts introduce optional params not yet supported in ecash-wallet. The published version of ecash-wallet will not be on this version of ecash-lib until D18867 lands, so no behavior change is expected.

Test Plan

npm test, CI

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bytesofman created this revision.Mon, Nov 10, 17:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 10, 17:32

bytesofman edited the summary of this revision. (Show Details)Mon, Nov 10, 17:33

Harbormaster completed remote builds in B35038: Diff 56556.Mon, Nov 10, 17:43

bytesofman published this revision for review.Mon, Nov 10, 17:43

Fabien accepted this revision.Mon, Nov 10, 20:45

Fabien added a subscriber: Fabien.

Fabien added inline comments.

modules/ecash-lib/src/consts.ts
36 ↗	(On Diff #56556)

This revision is now accepted and ready to land.Mon, Nov 10, 20:45

bytesofman marked an inline comment as done.Mon, Nov 10, 20:46

Closed by commit rABC43d39e207b44: [ecash-lib] Export new constants and interfaces to be used for chained txs in… (authored by bytesofman). · Explain WhyMon, Nov 10, 20:47

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC43d39e207b44: [ecash-lib] Export new constants and interfaces to be used for chained txs in….

Revision Contents
Changeset List

Path

Size

modules/

ecash-lib/

1 line

package-lock.json

4 lines

2 lines

src/

9 lines

payment/

38 lines

Diff 56559

modules/ecash-lib/README.md

Loading...

modules/ecash-lib/package-lock.json

Loading...

modules/ecash-lib/package.json

Loading...

modules/ecash-lib/src/consts.ts

Loading...

modules/ecash-lib/src/payment/action.ts

Loading...