Page MenuHomePhabricator
Differential D18972

Remove utxo db upgrade code
ClosedPublic
Actions

Authored by PiRK on Thu, Nov 20, 10:08.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC33b97b07c28c: Remove utxo db upgrade code
Summary

We already require a full reindex for pre-0.22.8 versions (see D11355) so this upgrade code path from pre-0.15.0 versions is pointless and can be removed.

This is a backport of core#24236

Test Plan

This removes an untested code path, which has the lucky side-effect of increasing relative test coverage. So we just check that no existing test is accidentaly broken..
ninja all check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

PiRK created this revision.Thu, Nov 20, 10:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Nov 20, 10:08
PiRK requested review of this revision.Thu, Nov 20, 10:08
teamcity edited the summary of this revision. (Show Details)Thu, Nov 20, 10:08
Harbormaster completed remote builds in B35127: Diff 56691.Thu, Nov 20, 10:27
PiRK added a comment.Thu, Nov 20, 10:35

Note that if this is merged it will replace D18970 and require a rebase the rest of that stack (some changes in D18966 are no longer relevant)

Fabien accepted this revision.Thu, Nov 20, 11:02
This revision is now accepted and ready to land.Thu, Nov 20, 11:02
Closed by commit rABC33b97b07c28c: Remove utxo db upgrade code (authored by MarcoFalke <falke.marco@gmail.com>, committed by PiRK). · Explain WhyThu, Nov 20, 12:07
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC33b97b07c28c: Remove utxo db upgrade code.

Revision Contents
Changeset List

PathSize
src/
node/
8 lines
5 lines
140 lines

Diff 56693

View Options

src/node/chainstate.cpp

Loading...
View Options

src/txdb.h

Loading...
View Options

src/txdb.cpp

Loading...