Paths

Table of Contentst

Differential D19034

crypto: refactor ChaCha20 classes to use Span<std::byte> interface
Needs ReviewPublic
Actions

Authored by PiRK on Wed, Dec 3, 14:13.

Details

Reviewers

None

Group Reviewers

Restricted Project

Summary

This is a partial backport of core#28100
https://github.com/bitcoin/bitcoin/pull/28100/commits/3da636e08b781fa2f7c1c23bb937015185732a75

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 35210
Build 69878: Build Diff	build-bench · build-without-wallet · build-fuzzer · build-diff · build-clang · lint-circular-dependencies · build-clang-tidy · build-debug
Build 69877: arc lint + arc unit

Event Timeline

PiRK created this revision.Wed, Dec 3, 14:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Dec 3, 14:13

PiRK requested review of this revision.Wed, Dec 3, 14:13

teamcity edited the summary of this revision. (Show Details)Wed, Dec 3, 14:13

PiRK added a child revision: D19035: random: simplify FastRandomContext::randbytes using fillrand.Wed, Dec 3, 14:16

Harbormaster completed remote builds in B35210: Diff 56842.Wed, Dec 3, 14:32

Revision Contents
Changeset List

Path

Size

src/

bench/

chacha20.cpp

13 lines

crypto/

80 lines

130 lines

34 lines

4 lines

6 lines

15 lines

test/

crypto_tests.cpp

72 lines

fuzz/

crypto_chacha20.cpp

43 lines

Diff 56842

View Options

src/bench/chacha20.cpp

View Options

src/crypto/chacha20.h

View Options

src/crypto/chacha20.cpp

View Options

src/crypto/chacha20poly1305.cpp

View Options

src/crypto/muhash.cpp

View Options

src/random.h

View Options

src/random.cpp

View Options

src/test/crypto_tests.cpp

View Options

src/test/fuzz/crypto_chacha20.cpp

crypto: refactor ChaCha20 classes to use Span<std::byte> interfaceNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 56842

src/bench/chacha20.cpp

src/crypto/chacha20.h

src/crypto/chacha20.cpp

src/crypto/chacha20poly1305.cpp

src/crypto/muhash.cpp

src/random.h

src/random.cpp

src/test/crypto_tests.cpp

src/test/fuzz/crypto_chacha20.cpp

crypto: refactor ChaCha20 classes to use Span<std::byte> interface
Needs ReviewPublic
Actions

Revision Contents
Changeset List