Differential D1953

Add Clang thread safety annotations for variables guarded by CAddrMan.cs
AbandonedPublic
Actions

Authored by Fabien on Oct 21 2018, 12:58.

Details

Reviewers

schancel

Group Reviewers

Restricted Project

Summary

Backport of core PR 13115

Test Plan

./src/test/test_bitcoin -t addrman_tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3640
Build 5355: Bitcoin ABC Buildbot (legacy)
Build 5354: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 21 2018, 12:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 21 2018, 12:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3640: Diff 5478.Oct 21 2018, 13:11

schancel added a subscriber: schancel.Oct 22 2018, 20:31

schancel added inline comments.

src/addrman.h
306	These annotations don't seem right. Which public APIs are calling private APIs with the internal (private) lock held?

schancel requested changes to this revision.Oct 22 2018, 20:31

This revision now requires changes to proceed.Oct 22 2018, 20:31

This revision is no longer needed

src/addrman.h
306	I agree. This was part of an effort to backport changes on addrman from core in order to fix a sporadic unit test failure. The issue has been fixed in D1954, this diff can be removed.

Revision Contents
Changeset List

Path

Size

src/

addrman.h

59 lines

test/

addrman_tests.cpp

8 lines

Diff 5478

View Options

src/addrman.h