Page MenuHomePhabricator

Fix sources of flackiness in p2p-fullblocktest.py
ClosedPublic

Authored by deadalnix on Sun, Nov 18, 23:25.

Details

Summary

Some of the test end up being dependent on transaction order (base on ids) and therefore flacky.

Test Plan
./test/functional/test_runner.py p2p-fullblocktest.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sun, Nov 18, 23:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Nov 18, 23:25
schancel accepted this revision.Sun, Nov 18, 23:27
schancel added a subscriber: schancel.
schancel added inline comments.
test/functional/p2p-fullblocktest.py
808 ↗(On Diff #5900)

This is why I used the merkleRootDirectly.

This revision is now accepted and ready to land.Sun, Nov 18, 23:27
This revision was automatically updated to reflect the committed changes.