Remove the virtual specifier for functions with the override specifier
ClosedPublic
Actions

Authored by deadalnix on May 26 2019, 18:07.

Details

Reviewers

markblundeberg

Group Reviewers

Restricted Project

Commits

rSTAGINGb865fe7e333a: Remove the virtual specifier for functions with the override specifier
rABCb865fe7e333a: Remove the virtual specifier for functions with the override specifier

Summary

override guarantees that the function is virtual (in addition
to that the function is overriding a virtual function from a base
class).

This is backport of Core PR10701

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.May 26 2019, 18:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2019, 18:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5990: Diff 8883.May 26 2019, 18:21

note: Logv already has virtual removed

https://github.com/bitcoin/bitcoin/pull/10701/files

This revision is now accepted and ready to land.May 27 2019, 00:47

Closed by commit rABCb865fe7e333a: Remove the virtual specifier for functions with the override specifier (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by deadalnix). · Explain WhyMay 27 2019, 00:59

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCb865fe7e333a: Remove the virtual specifier for functions with the override specifier.

deadalnix added a commit: rSTAGINGb865fe7e333a: Remove the virtual specifier for functions with the override specifier.Sep 18 2019, 23:47

Revision Contents
Changeset List

Path

Size

src/

keystore.h

16 lines

Diff 8895

View Options

Remove the virtual specifier for functions with the override specifierClosedPublicActions