Page MenuHomePhabricator
Differential D3150

wallet: Display non-HD error on first run
ClosedPublic
Actions

Authored by Fabien on May 29 2019, 19:30.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING02fdf38becff: wallet: Display non-HD error on first run
rABC02fdf38becff: wallet: Display non-HD error on first run
Summary
On current master a fresh wallet created with -usehd=0 is silently
created as HD wallet.
An error should be displayed on the first run.

Also, this restores a test that was removed in c22a53c

Fixes: #11313

Backport of core PR11307
https://github.com/bitcoin/bitcoin/pull/11307/files

Test Plan
./test/functional/test_runner.py wallet_hd

mkdir /tmp/wallet
./src/bitcoind -walletdir=/tmp/wallet -usehd=0

Should return an init error:

Error: Error creating : You can't create non-HD wallets with this
version.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.May 29 2019, 19:30
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 29 2019, 19:30
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 29 2019, 19:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added inline comments.May 29 2019, 19:32
src/wallet/wallet.cpp
4316 ↗(On Diff #8986)

You may notice that the error belongs to the above case. This is a mistake which is fixed by the removal in this diff.

teamcity added a comment.May 29 2019, 19:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6050: Diff 8986.May 29 2019, 19:44
deadalnix accepted this revision.May 29 2019, 20:41
This revision is now accepted and ready to land.May 29 2019, 20:41
Closed by commit rABC02fdf38becff: wallet: Display non-HD error on first run (authored by MarcoFalke <falke.marco@gmail.com>, committed by Fabien). · Explain WhyMay 29 2019, 21:24
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC02fdf38becff: wallet: Display non-HD error on first run.
Fabien added a commit: rSTAGING02fdf38becff: wallet: Display non-HD error on first run.Sep 18 2019, 23:53

Revision Contents
Changeset List

PathSize
src/
wallet/
2 lines
11 lines
test/
functional/
9 lines

Diff 8990

View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/wallet_hd.py

Loading...