Differential D3179

Improve ZMQ functional test
ClosedPublic
Actions

Authored by Fabien on Jun 3 2019, 09:10.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGc747648744db: Improve ZMQ functional test
rABCc747648744db: Improve ZMQ functional test

Summary

[...], this PR only improves:
  - test comments;
  - simplicity by removing duplicate tests;
  - also removes duplicate code.

Backport of core PR11452
https://github.com/bitcoin/bitcoin/pull/11452/files

Test Plan

./test/functional/test_runner.py interface_zmq

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jun 3 2019, 09:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptJun 3 2019, 09:10

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6115: Diff 9077.Jun 3 2019, 09:25

deadalnix accepted this revision.Jun 3 2019, 12:38

This revision is now accepted and ready to land.Jun 3 2019, 12:38

Closed by commit rABCc747648744db: Improve ZMQ functional test (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by Fabien). · Explain WhyJun 3 2019, 16:37

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCc747648744db: Improve ZMQ functional test.

Fabien added a commit: rSTAGINGc747648744db: Improve ZMQ functional test.Sep 18 2019, 23:58

Revision Contents
Changeset List

Path

Size

test/

functional/

interface_zmq.py

182 lines

Diff 9087

View Options

test/functional/interface_zmq.py

Improve ZMQ functional testClosedPublicActions