Page MenuHomePhabricator

Merge #12616: Set modal overlay hide button as default
ClosedPublic

Authored by jasonbcox on Tue, Jun 4, 22:35.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC93b0e7c2ec61: Merge #12616: Set modal overlay hide button as default
Summary

cfdd89589 qt: Set modal overlay hide button as default (João Barbosa)

Pull request description:

Without this change the only way to close the modal overlay is to click the hide button. Setting the button to default allows to activate it with the ENTER key.

Before:
<img width="849" alt="screen shot 2018-03-06 at 15 14 23" src="https://user-images.githubusercontent.com/3534524/37040276-58af9ce0-2151-11e8-8c55-50acdea669d9.png">

After:
<img width="848" alt="screen shot 2018-03-06 at 15 12 41" src="https://user-images.githubusercontent.com/3534524/37040294-650d1c9c-2151-11e8-8245-2da250a71b3d.png">

Tree-SHA512: a93ef440a507843ed7870fd07a693af93dd97c8fce2fb6824c69a227b5dee258f340bf1ae344da32a9dd6e6cb2330f72db9dac9635bbd34184c3e7f8476a472e

Backport of Core PR12616
https://github.com/bitcoin/bitcoin/pull/12616

Test Plan
make check
bitcoin-qt
# Hit Enter key once the progress modal appears. The modal should hide.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.