Paths

Table of Contentst

Differential D3380

Merge #12250: Make CKey::Load references const
ClosedPublic
Actions

Authored by jasonbcox on Jun 21 2019, 17:23.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGc5ffc02fe6fe: Merge #12250: Make CKey::Load references const
rABCc5ffc02fe6fe: Merge #12250: Make CKey::Load references const

Summary

04ededf Make CKey::Load references const (Russell Yanofsky)

Pull request description:

No change in behavior, this just prevents CKey::Load arguments from looking
like outputs.

Tree-SHA512: 6d93bce109318e88ddd5c21ad626571344707ae0e6d46e898c76fd95a7afd1c32202a6b3dfab47d6a787c84dfcbb35343cdec898bcf8f668574aa224f2eed977

Backport of Core PR12250

https://github.com/bitcoin/bitcoin/pull/12250/files

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jun 21 2019, 17:23

Herald added a reviewer: deadalnix. · View Herald TranscriptJun 21 2019, 17:23

jasonbcox planned changes to this revision.Jun 21 2019, 17:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6430: Diff 9570.Jun 21 2019, 17:34

jasonbcox requested review of this revision.Jun 21 2019, 17:35

deadalnix accepted this revision.Jun 22 2019, 02:12

This revision is now accepted and ready to land.Jun 22 2019, 02:12

Closed by commit rABCc5ffc02fe6fe: Merge #12250: Make CKey::Load references const (authored by jasonbcox). · Explain WhyJun 24 2019, 17:41

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABCc5ffc02fe6fe: Merge #12250: Make CKey::Load references const.

jasonbcox added a commit: rSTAGINGc5ffc02fe6fe: Merge #12250: Make CKey::Load references const.Sep 19 2019, 00:29

Revision Contents
Changeset List

Path

Size

src/

key.h

3 lines

key.cpp

2 lines

Diff 9622

View Options

src/key.h