Page MenuHomePhabricator

Merge #11210: Stop test_bitcoin-qt touching ~/.bitcoin
ClosedPublic

Authored by jasonbcox on Jun 27 2019, 17:29.

Details

Summary

dea086f49 Stop test_bitcoin-qt touching ~/.bitcoin (MeshCollider)

Pull request description:

Fixes https://github.com/bitcoin/bitcoin/issues/11192

The directory remains unused, but this stops the tests touching ~/.bitcoin at all (namely creating it if it doesn't exist)

Tree-SHA512: e59ad6b83dbc5ea2fb2761994c09933721d29668b0eef09b9d938a4ee1c67871c5125c57483ee0ea25f2385e308d275d86bcb9087dd4d502923013b4f3dbac82

Backport of Core PR11210

https://github.com/bitcoin/bitcoin/pull/11210/files

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/qt/test/test_main.cpp
56 ↗(On Diff #9724)

src/test/test_bitcoin.cpp uses InsecureRandRange() (defined in src/test/test_bitcoin.h) instead of GetRand(), but Core has not migrated this call even on latest master. Leaving this as-is for now.

This revision is now accepted and ready to land.Jun 28 2019, 01:27