Paths

Table of Contentst

Differential D3517

[LINTER] Fix the python format string when dealing with arrays
ClosedPublic
Actions

Authored by Fabien on Jul 2 2019, 13:03.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGfacbb283229e: [LINTER] Fix the python format string when dealing with arrays
rABCfacbb283229e: [LINTER] Fix the python format string when dealing with arrays

Summary

Thanks to Mark for finding the bug.

The lint-python-format.py linter failed the transformation when the
qualifier was an array. This diff adds the case management and update
the tests accordingly.

Test Plan

Should return nothing:

./test/lint/lint-python-format.py

arc lint --everything

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jul 2 2019, 13:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 2 2019, 13:03

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B6620: Diff 9906.Jul 2 2019, 13:10

deadalnix accepted this revision.Jul 3 2019, 01:12

This revision is now accepted and ready to land.Jul 3 2019, 01:12

Closed by commit rABCfacbb283229e: [LINTER] Fix the python format string when dealing with arrays (authored by Fabien). · Explain WhyJul 3 2019, 15:05

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCfacbb283229e: [LINTER] Fix the python format string when dealing with arrays.

Fabien added a commit: rSTAGINGfacbb283229e: [LINTER] Fix the python format string when dealing with arrays.Sep 19 2019, 00:54

Revision Contents
Changeset List

Path

Size

test/

lint/

lint-python-format-tests.txt

10 lines

lint-python-format.py

17 lines

Diff 9961

View Options

test/lint/lint-python-format-tests.txt