Page MenuHomePhabricator

[LINTER] Fix check-doc linter returning the same error multiple times
AbandonedPublic

Authored by Fabien on Jul 22 2019, 12:16.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Summary

Thanks to @deadalnix for pointing out the issue.

The check-doc linter will scan for all the errors for each file, thus
duplicating the error messages is multiple files are being modified.

This diff ensures that the messages are generated once. This is a
temporary fix, waiting for a solution to make the linter run once.

Test Plan

Comment an exception in the test/lint/check-doc.py file.

arc lint --everything

The error should be catched by the linter and displayed only once.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
linter_check_doc_fix_return_once
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6900
Build 11847: Bitcoin ABC Buildbot (legacy)
Build 11846: arc lint + arc unit

Event Timeline

What happened to the idea of a linter running once?

@deadalnix As stated in the summary, this is a temporary fix. I'm still searching for a good solution to run the linter once.

If D3705 is getting accepted, this fix is becoming useless and won't need review.

deadalnix requested changes to this revision.Jul 23 2019, 17:34

This seems to be deprecated in favor of D3705

This revision now requires changes to proceed.Jul 23 2019, 17:34