Differential D3962

Increase timeout on avalanche test.
ClosedPublic
Actions

Authored by deadalnix on Aug 28 2019, 15:22.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGc11d7ea6613d: Increase timeout on avalanche test.
rABCc11d7ea6613d: Increase timeout on avalanche test.

Summary

This shouldn't be an issue, because the loop break as soon as the event is reached.

Test Plan

Run the test and check there was no failure, and that it did not take forever to run.

As the issue cannot be reproduced reliably, this cannot ensure that this fixes it, but it should be enough.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Aug 28 2019, 15:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 28 2019, 15:22

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien requested changes to this revision.Aug 28 2019, 15:28

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/test/avalanche_tests.cpp
801 ↗	(On Diff #10996)	5 minutes

This revision now requires changes to proceed.Aug 28 2019, 15:28

Harbormaster completed remote builds in B7261: Diff 10996.Aug 28 2019, 15:29

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Actually do wait for 1 minute

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7262: Diff 10997.Aug 28 2019, 15:37

Fabien accepted this revision.Aug 28 2019, 15:46

This revision is now accepted and ready to land.Aug 28 2019, 15:46

Closed by commit rABCc11d7ea6613d: Increase timeout on avalanche test. (authored by deadalnix). · Explain WhyAug 28 2019, 16:14

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCc11d7ea6613d: Increase timeout on avalanche test..

deadalnix added a commit: rSTAGINGc11d7ea6613d: Increase timeout on avalanche test..Sep 19 2019, 02:03

Revision Contents
Changeset List

Path

Size

src/

test/

avalanche_tests.cpp

4 lines

Diff 10998

View Options

src/test/avalanche_tests.cpp

Increase timeout on avalanche test.ClosedPublicActions