Differential D4092

Use C++11 default member initializers
ClosedPublic
Actions

Authored by deadalnix on Sep 16 2019, 11:39.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING08af61078c59: Use C++11 default member initializers
rABC08af61078c59: Use C++11 default member initializers

Summary

This is a backport of Core PR15144

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Sep 16 2019, 11:39

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 16 2019, 11:39

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7477: Diff 11342.Sep 16 2019, 11:48

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien requested changes to this revision.Sep 17 2019, 06:05

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/net.h
686 ↗	(On Diff #11342)	The comment from the PR is missing
688 ↗	(On Diff #11342)	Dito

This revision now requires changes to proceed.Sep 17 2019, 06:05

Add comments

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien accepted this revision.Sep 17 2019, 09:22

This revision is now accepted and ready to land.Sep 17 2019, 09:22

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7489: Diff 11359.Sep 17 2019, 09:28

Closed by commit rABC08af61078c59: Use C++11 default member initializers (authored by MarcoFalke <falke.marco@gmail.com>, committed by deadalnix). · Explain WhySep 17 2019, 10:36

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC08af61078c59: Use C++11 default member initializers.

deadalnix added a commit: rSTAGING08af61078c59: Use C++11 default member initializers.Sep 19 2019, 02:24

Revision Contents
Changeset List

Path

Size

src/

net.h

88 lines

net.cpp

45 lines

Diff 11360

View Options

src/net.h