[CMAKE] Remove useless dependency for the check-rpcauth target
ClosedPublic
Actions

Authored by Fabien on Sep 20 2019, 09:59.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING093479065d92: [CMAKE] Remove useless dependency for the check-rpcauth target
rABC093479065d92: [CMAKE] Remove useless dependency for the check-rpcauth target

Summary

The DEPENDS property of a custom target instructs cmake to bring the
files up to date prior to running the command.
The share/rpcauth.py is not generated but is a source file, then
having it in the DEPENDS makes no sense.

Test Plan

mkdir buildcmake && cd buildcmake
cmake -GNinja ..
ninja check-rpcauth

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Sep 20 2019, 09:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 20 2019, 09:59

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7518: Diff 13023.Sep 20 2019, 10:10

deadalnix accepted this revision.Sep 20 2019, 16:55

This revision is now accepted and ready to land.Sep 20 2019, 16:55

Closed by commit rABC093479065d92: [CMAKE] Remove useless dependency for the check-rpcauth target (authored by Fabien). · Explain WhySep 23 2019, 08:38

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC093479065d92: [CMAKE] Remove useless dependency for the check-rpcauth target.

Fabien added a commit: rSTAGING093479065d92: [CMAKE] Remove useless dependency for the check-rpcauth target.Sep 27 2019, 22:47

Revision Contents
Changeset List

Path

Size

test/

CMakeLists.txt

1 line

Diff 13074

View Options

[CMAKE] Remove useless dependency for the check-rpcauth targetClosedPublicActions