Page MenuHomePhabricator

tiny refactor for ArgsManager
ClosedPublic

Authored by deadalnix on Fri, Sep 27, 14:16.

Details

Summary

This commit contains 2 refactors.

  1. mark "const" on ArgsManager::GetHelpMessage and IsArgKnown.
  2. remove unused "error" argument from ArgsManager::IsArgKnown.

Firstly, I mark "const" on where it is possible to. It is mentioned
before (e.g. https://github.com/bitcoin/bitcoin/pull/13190#pullrequestreview-118823133).

And about 2nd change, ArgsManager::IsArgKnown was added at commit #4f8704d which was
merged at PR #13112. But from its beggining, "error" argument never be used.
I think it should be refactored.

This is a backport of Core PR13733

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Fri, Sep 27, 14:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Sep 27, 14:16
jasonbcox accepted this revision.Fri, Sep 27, 22:00
This revision is now accepted and ready to land.Fri, Sep 27, 22:00
This revision was automatically updated to reflect the committed changes.