Page MenuHomePhabricator

[CMAKE] Add resource file to bitcoin-qt
ClosedPublic

Authored by Fabien on Oct 15 2019, 08:37.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC1c3cb55f195b: [CMAKE] Add resource file to bitcoin-qt
Summary

The resource file is missing from bitcoin-qt in the windows build. Other
executables have the resource file set correctly.

Test Plan
Cross build for Windows with CMake. Check the `bitcoin-qt.exe`

executable embeds its icon.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Oct 15 2019, 08:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 15 2019, 08:37
deadalnix accepted this revision.Oct 15 2019, 10:38
This revision is now accepted and ready to land.Oct 15 2019, 10:38
This revision was automatically updated to reflect the committed changes.