Page MenuHomePhabricator
Differential D4455

add a couple more Schnorr checkmultisig tests
ClosedPublic
Actions

Authored by markblundeberg on Nov 17 2019, 02:11.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING7b6969f08418: add a couple more Schnorr checkmultisig tests
rABC7b6969f08418: add a couple more Schnorr checkmultisig tests
Summary
  • a test with a one-byte checkbits not pushed using OP_1-OP_1NEGATE.
  • a test with a two-byte checkbits.

Also re-disable auto script gen (was inadvertently activated in D3474).
The auto script gen should generally be kept off since it allows the tester
to emit "Missing auto script_valid test" in case that the generator has
been changed somehow and impacted existing tests.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg created this revision.Nov 17 2019, 02:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 17 2019, 02:11
teamcity added a comment.Nov 17 2019, 02:12

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 17 2019, 02:12

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 17 2019, 02:21

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Nov 17 2019, 02:21

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8136: Diff 14162.Nov 17 2019, 02:21
markblundeberg added inline comments.Nov 17 2019, 02:25
src/test/script_tests.cpp
2278 ↗(On Diff #14162)

^ this is the consistency test mentioned in the commit message

deadalnix accepted this revision.Nov 17 2019, 23:14

More test is always welcome, unless they are flaky or slow as shit.

src/test/script_tests.cpp
39 ↗(On Diff #14162)

Congratulations, you played yourself :)

This revision is now accepted and ready to land.Nov 17 2019, 23:14
Closed by commit rABC7b6969f08418: add a couple more Schnorr checkmultisig tests (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyNov 20 2019, 23:00
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABC7b6969f08418: add a couple more Schnorr checkmultisig tests.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING7b6969f08418: add a couple more Schnorr checkmultisig tests.Apr 7 2020, 21:45

Revision Contents
Changeset List

PathSize
src/
test/
data/
14 lines
18 lines

Diff 14279

View Options

src/test/data/script_tests.json

Loading...
View Options

src/test/script_tests.cpp

Loading...