Page MenuHomePhabricator

add a couple more Schnorr checkmultisig tests
ClosedPublic

Authored by markblundeberg on Nov 17 2019, 02:11.

Details

Summary
  • a test with a one-byte checkbits not pushed using OP_1-OP_1NEGATE.
  • a test with a two-byte checkbits.

Also re-disable auto script gen (was inadvertently activated in D3474).
The auto script gen should generally be kept off since it allows the tester
to emit "Missing auto script_valid test" in case that the generator has
been changed somehow and impacted existing tests.

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

src/test/script_tests.cpp
2278 ↗(On Diff #14162)

^ this is the consistency test mentioned in the commit message

More test is always welcome, unless they are flaky or slow as shit.

src/test/script_tests.cpp
39 ↗(On Diff #14162)

Congratulations, you played yourself :)

This revision is now accepted and ready to land.Nov 17 2019, 23:14