Page MenuHomePhabricator

Move BitcoinApplication to header so it can be tested
ClosedPublic

Authored by Fabien on Nov 21 2019, 09:09.

Details

Summary

Move-only commit, no code changes

Partial backport of core PR11625 (commit 7e4bd19)
https://github.com/bitcoin/bitcoin/pull/11625/commits/ca20b65cc04825bb317f1a59d02c77912f6bf097

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix requested changes to this revision.Nov 21 2019, 12:09
deadalnix added inline comments.
src/qt/bitcoin.h
12 ↗(On Diff #14284)

You don't need this.

14 ↗(On Diff #14284)

You probably don't need these two either.

This revision now requires changes to proceed.Nov 21 2019, 12:09

Use forward declarations

This revision is now accepted and ready to land.Nov 21 2019, 14:36