Page MenuHomePhabricator
Differential D4537

Revert use of size_t in ParseParameters
ClosedPublic
Actions

Authored by jasonbcox on Nov 25 2019, 17:33.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING1fd348979cfd: Revert use of size_t in ParseParameters
rABC1fd348979cfd: Revert use of size_t in ParseParameters
Summary

Introduced in D4496

Test Plan

ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Nov 25 2019, 17:33
Herald added a reviewer: deadalnix. · View Herald TranscriptNov 25 2019, 17:34
deadalnix requested changes to this revision.Nov 25 2019, 17:38

Clearly, size_t was the wrong type.

This revision now requires changes to proceed.Nov 25 2019, 17:38
teamcity added a comment.Nov 25 2019, 18:04

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 25 2019, 18:25

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8269: Diff 14381.Nov 25 2019, 18:25
jasonbcox updated this revision to Diff 14401.Nov 25 2019, 19:44

Change type

jasonbcox retitled this revision from Fix signed to unsigned int cast warning to Revert use of size_t in ParseParameters.Nov 25 2019, 19:44
teamcity added a comment.Nov 25 2019, 20:23

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 25 2019, 20:41

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8276: Diff 14401.Nov 25 2019, 20:41
deadalnix requested changes to this revision.Nov 25 2019, 22:17

Fix diff title/description.

This revision now requires changes to proceed.Nov 25 2019, 22:17
jasonbcox requested review of this revision.Nov 25 2019, 23:44

I already did this prior to you red'ing the diff.

deadalnix accepted this revision.Nov 26 2019, 00:27
This revision is now accepted and ready to land.Nov 26 2019, 00:27
Closed by commit rABC1fd348979cfd: Revert use of size_t in ParseParameters (authored by jasonbcox). · Explain WhyNov 26 2019, 01:46
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC1fd348979cfd: Revert use of size_t in ParseParameters.
jasonbcox added a commit: rSTAGING1fd348979cfd: Revert use of size_t in ParseParameters.Apr 7 2020, 21:51

Revision Contents
Changeset List

PathSize
src/
util/
2 lines

Diff 14419

View Options

src/util/system.cpp

Loading...