Page MenuHomePhabricator

Revert use of size_t in ParseParameters
ClosedPublic

Authored by jasonbcox on Mon, Nov 25, 17:33.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC1fd348979cfd: Revert use of size_t in ParseParameters
Summary

Introduced in D4496

Test Plan

ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Mon, Nov 25, 17:33
deadalnix requested changes to this revision.Mon, Nov 25, 17:38

Clearly, size_t was the wrong type.

This revision now requires changes to proceed.Mon, Nov 25, 17:38
jasonbcox updated this revision to Diff 14401.Mon, Nov 25, 19:44

Change type

jasonbcox retitled this revision from Fix signed to unsigned int cast warning to Revert use of size_t in ParseParameters.Mon, Nov 25, 19:44
deadalnix requested changes to this revision.Mon, Nov 25, 22:17

Fix diff title/description.

This revision now requires changes to proceed.Mon, Nov 25, 22:17
jasonbcox requested review of this revision.Mon, Nov 25, 23:44

I already did this prior to you red'ing the diff.

deadalnix accepted this revision.Tue, Nov 26, 00:27
This revision is now accepted and ready to land.Tue, Nov 26, 00:27
This revision was automatically updated to reflect the committed changes.