Page MenuHomePhabricator

Revert use of size_t in ParseParameters
ClosedPublic

Authored by jasonbcox on Nov 25 2019, 17:33.

Details

Summary

Introduced in D4496

Test Plan

ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix requested changes to this revision.Nov 25 2019, 17:38

Clearly, size_t was the wrong type.

This revision now requires changes to proceed.Nov 25 2019, 17:38
jasonbcox retitled this revision from Fix signed to unsigned int cast warning to Revert use of size_t in ParseParameters.Nov 25 2019, 19:44
deadalnix requested changes to this revision.Nov 25 2019, 22:17

Fix diff title/description.

This revision now requires changes to proceed.Nov 25 2019, 22:17

I already did this prior to you red'ing the diff.

This revision is now accepted and ready to land.Nov 26 2019, 00:27
This revision was automatically updated to reflect the committed changes.