Page MenuHomePhabricator

Fix activation_tests
ClosedPublic

Authored by deadalnix on Fri, Nov 29, 16:22.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCa6af523bafce: Fix activation_tests
Summary

The check for the null case was removed in a previous patch. This is a mistake as nullptr is passed down when checking for activation for the genesis block - it has no parent.

Also change an assert into a BOOST_CHECK_EQUAL for better error report.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Fri, Nov 29, 16:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Nov 29, 16:22
Fabien accepted this revision.Fri, Nov 29, 19:41
This revision is now accepted and ready to land.Fri, Nov 29, 19:41
This revision was automatically updated to reflect the committed changes.