Page MenuHomePhabricator

[cmake] link test runners by default
ClosedPublic

Authored by deadalnix on Sun, Dec 1, 02:19.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC36791c4a595c: [cmake] link test runners by default
Summary

This is not an expensive operation, is properly tracked by dependencies and ensure the presence of these file is predictable.

Test Plan
rm test/functional/test_runner.py
ninja

Check test/functional/test_runner.py was linked.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sun, Dec 1, 02:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptSun, Dec 1, 02:19
deadalnix updated this revision to Diff 14547.Sun, Dec 1, 02:30

map the sanitization with cmake doc ( https://cmake.org/cmake/help/v3.10/policy/CMP0037.html ) and reduce verbosity.

deadalnix updated this revision to Diff 14548.Sun, Dec 1, 02:37

Use absolute path

Fabien accepted this revision.Mon, Dec 2, 08:47
Fabien added a subscriber: Fabien.

Thanks, this one was on my list :)

This revision is now accepted and ready to land.Mon, Dec 2, 08:47
This revision was automatically updated to reflect the committed changes.