[Backport] Never bind INADDR_ANY by default, and warn when doing so explicitly
AbandonedPublic
Actions

Authored by ProtocolCash on Dec 4 2019, 22:27.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

Backport of Bitcoin Core PR#14532

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR14532

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8416
Build 14847: Default Diff Build & Tests
Build 14846: arc lint + arc unit

Event Timeline

ProtocolCash created this revision.Dec 4 2019, 22:27

Owners added a reviewer: Restricted Owners Package.Dec 4 2019, 22:27

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 4 2019, 22:27

Herald added a reviewer: deadalnix. · View Herald Transcript

Bad diff... missing commits.

Please mention PR1243653 (with no # in the middle) in the description so that it can be searched for.

src/httpserver.cpp
343	This clearly does not match what's in master at the moment, so you probably did something wrong here.

In D4640#111734, @deadalnix wrote:

Please mention PR1243653 (with no # in the middle) in the description so that it can be searched for.

Understood.

And, yes, this was a indeed bad diff... Figuring out why that happened.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B8416: Diff 14629!Dec 4 2019, 22:46

Revision Contents
Changeset List

Path

Size

src/

httpserver.cpp

17 lines

Diff 14629

View Options

[Backport] Never bind INADDR_ANY by default, and warn when doing so explicitlyAbandonedPublicActions