Hide linker visibility warnings on macOS
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project
Verified that all linker visibility warnings are hidden
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- hide-warnings (branched from master)
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 8702 Build 15390: Default Diff Build & Tests Build 15389: arc lint + arc unit
Event Timeline
Comment Actions
The test plan is not reproducible. This changes the depends build, which is not blurting a ton of error when I run it. Can you explains exactly what this is solving, and how to test that this is solved?
Comment Actions
This fix should be reproducible when compiling on macOS with the following steps:
$ ./autogen.sh
$ ./configure
$ make
Towards the end of the compilation, there are normally thousands of visibility warnings. After this commit, there should be none.
Comment Actions
Please give your full configure command line. This diff is changing the options for building the dependencies, but your instructions are for building the software.
This is unclear where the warnings happen: when building the dependencies ? When building the software against these dependencies ?
After this I can try to reproduce the issue.
Comment Actions
Hi Fabien,
All you should need is those 3 steps.
No need to touch the depends folder or compile anything in there.
Let me know if you can't reproduce it using the above steps.