Page MenuHomePhabricator

depends macOS: hide linker visibility warnings
Needs RevisionPublic

Authored by rex4539 on Dec 31 2019, 12:36.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

Hide linker visibility warnings on macOS

Test Plan

Verified that all linker visibility warnings are hidden

Diff Detail

Repository
rABC Bitcoin ABC
Branch
hide-warnings (branched from master)
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8702
Build 15390: Default Diff Build & Tests
Build 15389: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Dec 31 2019, 12:36
deadalnix requested changes to this revision.Jan 3 2020, 06:20

The test plan is not reproducible. This changes the depends build, which is not blurting a ton of error when I run it. Can you explains exactly what this is solving, and how to test that this is solved?

This revision now requires changes to proceed.Jan 3 2020, 06:20

This fix should be reproducible when compiling on macOS with the following steps:

$ ./autogen.sh
$ ./configure
$ make

Towards the end of the compilation, there are normally thousands of visibility warnings. After this commit, there should be none.

Please give your full configure command line. This diff is changing the options for building the dependencies, but your instructions are for building the software.
This is unclear where the warnings happen: when building the dependencies ? When building the software against these dependencies ?

After this I can try to reproduce the issue.

Hi Fabien,

All you should need is those 3 steps.

No need to touch the depends folder or compile anything in there.

Let me know if you can't reproduce it using the above steps.

Please close this diff.

Apologies for wasting people's time.