Page MenuHomePhabricator

[rpc] Finish backporting changes to prioritisetransaction's priority_delta argument
ClosedPublic

Authored by markblundeberg on Jan 4 2020, 02:09.

Details

Summary

prioritisetransaction RPC had this argument removed in PR9602, then re-added in
PR10252, then re-named in PR10488.
https://github.com/bitcoin/bitcoin/pull/9602/commits/f9b9371c6027905f73a2558d6bcaca8a355c28a6
https://github.com/bitcoin/bitcoin/pull/10252/files
https://github.com/bitcoin/bitcoin/pull/10488/files

Since the intermediate states are undesirable and I already did the renaming
to 'dummy' in D4812 (landed), this pulls together the overall remaining effects
of the PRs which are ultimately small:

  1. modify documentation slightly and force argument to be 0 instead of ignoring.
  2. change RPC tests to not pass priority, and use keyword arguments instead.
  3. simplify mining_prioritisetransaction test slightly (from 9602).

The release note is taken verbatim from Core's 0.15 release notes.

Test Plan

ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

src/rpc/mining.cpp
271 ↗(On Diff #15145)

this will be eventually changed 'back' in https://github.com/bitcoin/bitcoin/pull/14720/files#diff-9651347c8e00bed3ddc7631de569406dL235 but I think this is good for now

I also have the PR10252 and PR10488 as distinct commits and can make diffs from them (stacking off D4813) if that is preferred.

This revision is now accepted and ready to land.Jan 4 2020, 06:44