Page MenuHomePhabricator

[CMAKE] Don't use C++ features for building secp256k1
ClosedPublic

Authored by Fabien on Wed, Jan 8, 14:11.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABC3dea66f3fed8: [CMAKE] Don't use C++ features for building secp256k1
Summary

Secp256k1 is a pure C library. As such there should be no requirement
for a C++ compiler to be able to build it.

Test Plan

Build secp256k1 as part of bitcoin-abc and as a standalone project:

ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, Jan 8, 14:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jan 8, 14:11
deadalnix accepted this revision.Wed, Jan 8, 17:19
This revision is now accepted and ready to land.Wed, Jan 8, 17:19
This revision was automatically updated to reflect the committed changes.