Differential D4919

Fix -Wshadow warnings
ClosedPublic
Actions

Authored by Fabien on Jan 13 2020, 12:40.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGa383e5ddf95a: Fix -Wshadow warnings
rABCa383e5ddf95a: Fix -Wshadow warnings

Summary

These warnings have been introduced in D4891.

Test Plan

With GCC (for some reason clang -tested with 9.0.1- doesn't report the
warning):

cmake -GNinja .. -DCMAKE_CXX_FLAGS="-Werror=shadow"
ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 13 2020, 12:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 13 2020, 12:40

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix accepted this revision.Jan 13 2020, 12:42

This revision is now accepted and ready to land.Jan 13 2020, 12:42

This revision was landed with ongoing or failed builds.Jan 13 2020, 12:43

Closed by commit rABCa383e5ddf95a: Fix -Wshadow warnings (authored by Fabien). · Explain Why

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCa383e5ddf95a: Fix -Wshadow warnings.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8891: Diff 15390.Jan 13 2020, 12:47

Fabien added a commit: rSTAGINGa383e5ddf95a: Fix -Wshadow warnings.Apr 7 2020, 22:24

Revision Contents
Changeset List

Path

Size

src/

wallet/

db.h

4 lines

Diff 15391

View Options

Fix -Wshadow warningsClosedPublicActions