Page MenuHomePhabricator

Fix -Wshadow warnings
ClosedPublic

Authored by Fabien on Mon, Jan 13, 12:40.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rABCa383e5ddf95a: Fix -Wshadow warnings
Summary

These warnings have been introduced in D4891.

Test Plan

With GCC (for some reason clang -tested with 9.0.1- doesn't report the
warning):

cmake -GNinja .. -DCMAKE_CXX_FLAGS="-Werror=shadow"
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Mon, Jan 13, 12:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Jan 13, 12:40
deadalnix accepted this revision.Mon, Jan 13, 12:42
This revision is now accepted and ready to land.Mon, Jan 13, 12:42
This revision was landed with ongoing or failed builds.Mon, Jan 13, 12:43
This revision was automatically updated to reflect the committed changes.