Merge #12804: [tests] Fix intermittent rpc_net.py failure.
ClosedPublic
Actions

Authored by jasonbcox on Jan 16 2020, 23:02.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING5b51ba74e77a: Merge #12804: [tests] Fix intermittent rpc_net.py failure.
rABC5b51ba74e77a: Merge #12804: [tests] Fix intermittent rpc_net.py failure.

Summary

5a67c0524e [tests] Fix intermittent rpc_net.py failure. (John Newbery)

Pull request description:

rpc_net.py would intermittently fail on Travis, probably
due to assuming that two consecutive RPC calls were atomic.
Fix this by trying the test up to three times and only failing
if all three attempts fail.

fixes #11778

Tree-SHA512: f2f5047e05114ad2110377e6221ce057680c240952971fb33863834587d2250896c6b697ba27eef739cd0ab23faf47dfae8cafadc9833cbfab5a6f7e36dae5e2

Backport of Core PR12804
https://github.com/bitcoin/bitcoin/pull/12804/files

Test Plan

test_runner.py rpc_net

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Jan 16 2020, 23:02

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 16 2020, 23:02

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8988: Diff 15538.Jan 16 2020, 23:19

deadalnix accepted this revision.Jan 17 2020, 01:09

This revision is now accepted and ready to land.Jan 17 2020, 01:09

Closed by commit rABC5b51ba74e77a: Merge #12804: [tests] Fix intermittent rpc_net.py failure. (authored by MarcoFalke <falke.marco@gmail.com>, committed by jasonbcox). · Explain WhyJan 17 2020, 18:07

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC5b51ba74e77a: Merge #12804: [tests] Fix intermittent rpc_net.py failure..

jasonbcox added a commit: rSTAGING5b51ba74e77a: Merge #12804: [tests] Fix intermittent rpc_net.py failure..Apr 7 2020, 22:32

Revision Contents
Changeset List

Path

Size

test/

functional/

rpc_net.py

43 lines

Diff 15614

View Options

test/functional/rpc_net.py

Merge #12804: [tests] Fix intermittent rpc_net.py failure.ClosedPublicActions