Page MenuHomePhabricator
Differential D4976

secp256k1_fe_sqrt: Verify that the arguments don't alias.
ClosedPublic
Actions

Authored by deadalnix on Jan 17 2020, 01:29.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGc8e1ed5c96c9: secp256k1_fe_sqrt: Verify that the arguments don't alias.
rABCc8e1ed5c96c9: secp256k1_fe_sqrt: Verify that the arguments don't alias.
Summary

This is a backport of secp256k1's PR551

Test Plan
ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 17 2020, 01:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2020, 01:29
teamcity added a comment.Jan 17 2020, 01:30

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster failed remote builds in B8998: Diff 15549!Jan 17 2020, 01:32
teamcity added a comment.Jan 17 2020, 01:32
Build Bitcoin-ABC / Diffs / Diff Testing failed.

Snippet of first build failure:

[01:32:25] :	 [Step 1/1]  [0m [0;34mwallet_groups.py                        | ✓ Passed  | 14 s
[01:32:25] :	 [Step 1/1]  [0m [0;34mwallet_hd.py                            | ✓ Passed  | 4 s
[01:32:25] :	 [Step 1/1]  [0m [0;34mwallet_import_rescan.py                 | ✓ Passed  | 3 s
[01:32:25] :	 [Step 1/1]  [0m [0;34mwallet_importmulti.py                   | ✓ Passed  | 2 s
[01:32:25] :	 [Step 1/1]  [0m [0;34mwallet_importprunedfunds.py             | ✓ Passed  | 2 s
[01:32:25] :	 [Step 1/1]  [0m [0;34mwallet_keypool.py                       | ✓ Passed  | 3 s
[01:32:25] :	 [Step 1/1]  [0m [0;34mwallet_keypool_topup.py                 | ✓ Passed  | 3 s
[01:32:25] :	 [Step 1/1]  [0m [0;34mwallet_labels.py                        | ✓ Passed  | 2 s
[01:32:25] :	 [Step 1/1]  [0m [0;34mwallet_listreceivedby.py                | ✓ Passed  | 14 s
[01:32:25] :	 [Step 1/1]  [0m [0;34mwallet_listsinceblock.py                | ✓ Passed  | 3 s
[01:32:25] :	 [Step 1/1]  [0m [0;34mwallet_listtransactions.py              | ✓ Passed  | 8 s
[01:32:25] :	 [Step 1/1]  [0m [0;34mwallet_multiwallet.py                   | ✓ Passed  | 8 s
[01:32:25] :	 [Step 1/1]  [0m [0;34mwallet_multiwallet.py --usecli          | ✓ Passed  | 9 s
[01:32:25] :	 [Step 1/1]  [0m [0;34mwallet_resendwallettransactions.py      | ✓ Passed  | 1 s
[01:32:25] :	 [Step 1/1]  [0m [0;34mwallet_txn_clone.py                     | ✓ Passed  | 2 s
[01:32:25] :	 [Step 1/1]  [0m [0;34mwallet_txn_clone.py --mineblock         | ✓ Passed  | 3 s
[01:32:25] :	 [Step 1/1]  [0m [0;34mwallet_txn_doublespend.py               | ✓ Passed  | 2 s
[01:32:25] :	 [Step 1/1]  [0m [0;34mwallet_txn_doublespend.py --mineblock   | ✓ Passed  | 3 s
[01:32:25] :	 [Step 1/1]  [0m [0;34mwallet_zapwallettxes.py                 | ✓ Passed  | 2 s
[01:32:25] :	 [Step 1/1]  [0m [1m
[01:32:25] :	 [Step 1/1] ALL                                     | ✓ Passed  | 422 s (accumulated) 
[01:32:25] :	 [Step 1/1]  [0mRuntime: 96 s
[01:32:25] :	 [Step 1/1] 
[01:32:25] :	 [Step 1/1] [177/447] Building CXX object src/test/CMakeFiles/test_bitcoin.dir/script_tests.cpp.o
[01:32:25] :	 [Step 1/1] In file included from /usr/include/boost/test/unit_test.hpp:19,
[01:32:25] :	 [Step 1/1]                  from ../src/test/script_tests.cpp:29:
[01:32:25] :	 [Step 1/1] ../src/test/script_tests.cpp: In member function ‘void script_tests::script_build::test_method()’:
[01:32:25] :	 [Step 1/1] ../src/test/script_tests.cpp:575:22: note: variable tracking size limit exceeded with -fvar-tracking-assignments, retrying without
[01:32:25] :	 [Step 1/1]  BOOST_AUTO_TEST_CASE(script_build) {
[01:32:25] :	 [Step 1/1]                       ^~~~~~~~~~~~
[01:32:25] :	 [Step 1/1] [211/445] cd /home/teamcity/buildAgent/work/c4a5708f2bae7929/contrib/devtools/chainparams && /usr/bin/python3 ./test_make_chainparams.py
[01:32:25] :	 [Step 1/1] .....
[01:32:25] :	 [Step 1/1] ----------------------------------------------------------------------
[01:32:25] :	 [Step 1/1] Ran 5 tests in 0.001s
[01:32:25] :	 [Step 1/1] 
[01:32:25] :	 [Step 1/1] OK
[01:32:25] :	 [Step 1/1] [214/445] Running bitcoin-seeder test suite
[01:32:25] :	 [Step 1/1] PASSED: bitcoin-seeder test suite
[01:32:25] :	 [Step 1/1] [216/445] Running bitcoin-seeder-upgrade-activated test suite
[01:32:25] :	 [Step 1/1] PASSED: bitcoin-seeder-upgrade-activated test suite
[01:32:25] :	 [Step 1/1] [257/445] bitcoin: testing util_tests
[01:32:25] :	 [Step 1/1] FAILED: src/test/CMakeFiles/check-bitcoin-util_tests 
[01:32:25] :	 [Step 1/1] cd /home/teamcity/buildAgent/work/c4a5708f2bae7929/build/src/test && /home/teamcity/buildAgent/work/c4a5708f2bae7929/build/src/test/run-util_tests.sh
[01:32:25] :	 [Step 1/1] Running 37 test cases...
[01:32:25] :	 [Step 1/1] Running 37 test cases...
[01:32:25] :	 [Step 1/1] 
[01:32:25] :	 [Step 1/1] *** No errors detected
[01:32:25] :	 [Step 1/1] error: in "util_tests/test_LockDirectory": check LockDirectory(dirname, lockname, true) == true has failed [false != true]
[01:32:25] :	 [Step 1/1] 
[01:32:25]W:	 [Step 1/1] ++ print_sanitizers_log
[01:32:25] :	 [Step 1/1] *** 1 failure is detected in the test module "Bitcoin Test Suite"
[01:32:25]W:	 [Step 1/1] ++ for log in "${SAN_LOG_DIR}"/*.log.*
[01:32:25] :	 [Step 1/1] [269/445] leveldb: testing db_test
[01:32:25]W:	 [Step 1/1] ++ echo '*** Output of /tmp/sanitizer_logs/*.log.* ***'
[01:32:25] :	 [Step 1/1] ninja: build stopped: subcommand failed.
[01:32:25]W:	 [Step 1/1] ++ cat '/tmp/sanitizer_logs/*.log.*'
[01:32:25] :	 [Step 1/1] *** Output of /tmp/sanitizer_logs/*.log.* ***
[01:32:25]W:	 [Step 1/1] cat: '/tmp/sanitizer_logs/*.log.*': No such file or directory
[01:32:25]W:	 [Step 1/1] Process exited with code 1
[01:32:25]E:	 [Step 1/1] Process exited with code 1 (Step: Command Line)
Fabien accepted this revision.Jan 17 2020, 10:29
Fabien added a subscriber: Fabien.

Please consider backporting https://github.com/bitcoin-core/secp256k1/pull/591 to fix the bench issue that this check triggers.

This revision is now accepted and ready to land.Jan 17 2020, 10:29
This revision was landed with ongoing or failed builds.Jan 17 2020, 11:42
Closed by commit rABCc8e1ed5c96c9: secp256k1_fe_sqrt: Verify that the arguments don't alias. (authored by Russell O'Connor <roconnor@blockstream.io>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCc8e1ed5c96c9: secp256k1_fe_sqrt: Verify that the arguments don't alias..
deadalnix added a commit: rSTAGINGc8e1ed5c96c9: secp256k1_fe_sqrt: Verify that the arguments don't alias..Apr 7 2020, 22:30

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
2 lines

Diff 15564

View Options

src/secp256k1/src/field_impl.h

Loading...