Paths

Table of Contentst

Differential D4996

Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config
ClosedPublic
Actions

Authored by deadalnix on Jan 17 2020, 13:00.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGbea9546d907e: Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config
rABCbea9546d907e: Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config

Summary

Keep LDFLAGS if --coverage
Undefine STATIC_PRECOMPUTATION if using the basic config

This is a backport of secp256k1's PR561

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 17 2020, 13:00

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 17 2020, 13:00

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9019: Diff 15583.Jan 17 2020, 14:23

Fabien accepted this revision.Jan 17 2020, 15:20

This revision is now accepted and ready to land.Jan 17 2020, 15:20

Closed by commit rABCbea9546d907e: Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config (authored by DesWurstes <DesWurstes@users.noreply.github.com>, committed by deadalnix). · Explain WhyJan 17 2020, 16:14

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCbea9546d907e: Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config.

deadalnix added a commit: rSTAGINGbea9546d907e: Respect LDFLAGS and #undef STATIC_PRECOMPUTATION if using basic config.Apr 7 2020, 22:32

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

configure.ac

2 lines

src/

basic-config.h

1 line

Diff 15606

View Options

src/secp256k1/configure.ac