[cmake] Do not generate git_ignored_files.txt
ClosedPublic
Actions

Authored by deadalnix on Jan 18 2020, 23:22.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING3ed9038f912b: [cmake] Do not generate git_ignored_files.txt
rABC3ed9038f912b: [cmake] Do not generate git_ignored_files.txt

Summary

It is completely unecessary to write this file on disk and read it back again.

Test Plan

ninja

Added a message to check that _git_ignored_files indded contained the expected list.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Jan 18 2020, 23:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 18 2020, 23:22

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9059: Diff 15659.Jan 18 2020, 23:27

Fabien accepted this revision.Jan 20 2020, 10:51

This revision is now accepted and ready to land.Jan 20 2020, 10:51

Closed by commit rABC3ed9038f912b: [cmake] Do not generate git_ignored_files.txt (authored by deadalnix). · Explain WhyJan 20 2020, 14:26

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC3ed9038f912b: [cmake] Do not generate git_ignored_files.txt.

deadalnix added a commit: rSTAGING3ed9038f912b: [cmake] Do not generate git_ignored_files.txt.Apr 7 2020, 22:35

Revision Contents
Changeset List

Path

Size

cmake/

modules/

PackageHelper.cmake

13 lines

Diff 15685

View Options

cmake/modules/PackageHelper.cmake

[cmake] Do not generate git_ignored_files.txtClosedPublicActions