Page MenuHomePhabricator
Differential D5085

wallet: Releases dangling files on BerkeleyEnvironment::Close
ClosedPublic
Actions

Authored by Fabien on Jan 28 2020, 08:40.

Details

Reviewers
nakihito
Group Reviewers
Restricted Project
Commits
rSTAGINGb6affe11ba28: wallet: Releases dangling files on BerkeleyEnvironment::Close
rABCb6affe11ba28: wallet: Releases dangling files on BerkeleyEnvironment::Close
Summary
This PR closes db.log and removes .walletlock files when BerkeleyEnvironment is closed.

Backport of core PR15297.

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 28 2020, 08:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 28 2020, 08:40
teamcity edited the summary of this revision. (Show Details)Jan 28 2020, 08:41

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Jan 28 2020, 08:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Jan 28 2020, 08:47

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9163: Diff 15827.Jan 28 2020, 08:48
Fabien mentioned this in D5080: rpc: Make unloadwallet wait for complete wallet unload.Jan 28 2020, 09:33
nakihito accepted this revision.Jan 28 2020, 18:57
This revision is now accepted and ready to land.Jan 28 2020, 18:57
Closed by commit rABCb6affe11ba28: wallet: Releases dangling files on BerkeleyEnvironment::Close (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by Fabien). · Explain WhyJan 28 2020, 20:44
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCb6affe11ba28: wallet: Releases dangling files on BerkeleyEnvironment::Close.
Fabien added a commit: rSTAGINGb6affe11ba28: wallet: Releases dangling files on BerkeleyEnvironment::Close.Apr 7 2020, 22:41

Revision Contents
Changeset List

PathSize
src/
util/
2 lines
6 lines
wallet/
9 lines
test/
functional/
9 lines

Diff 15853

View Options

src/util/system.h

Loading...
View Options

src/util/system.cpp

Loading...
View Options

src/wallet/db.cpp

Loading...
View Options

test/functional/wallet_multiwallet.py

Loading...