Page MenuHomePhabricator

gui: Defer removeAndDeleteWallet when no modal widget is active
ClosedPublic

Authored by Fabien on Jan 28 2020, 08:59.

Details

Summary

Backport of core PR15614.

Test Plan
ninja check check-functional

./src/qt/bitcoin-qt -regtest -server -wallet=w1 &
./src/bitcoin-cli -regtest generate 1 # Get out of IBD if needed

Open the "Parameters=>Encrypt wallet" window and leave it open.

./src/bitcoin-cli -regtest unloadwallet=w1

Before this patch, the GUI crashes. After this patch, the GUI does
nothing, and closing the "Encrypt wallet" window does trigger the wallet
unloading.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Jan 28 2020, 19:03