gui: Defer removeAndDeleteWallet when no modal widget is active
ClosedPublic
Actions

Authored by Fabien on Jan 28 2020, 08:59.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGdd757132e348: gui: Defer removeAndDeleteWallet when no modal widget is active
rABCdd757132e348: gui: Defer removeAndDeleteWallet when no modal widget is active

Summary

Backport of core PR15614.

Test Plan

ninja check check-functional

./src/qt/bitcoin-qt -regtest -server -wallet=w1 &
./src/bitcoin-cli -regtest generate 1 # Get out of IBD if needed

Open the "Parameters=>Encrypt wallet" window and leave it open.

./src/bitcoin-cli -regtest unloadwallet=w1

Before this patch, the GUI crashes. After this patch, the GUI does
nothing, and closing the "Encrypt wallet" window does trigger the wallet
unloading.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Jan 28 2020, 08:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 28 2020, 08:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9164: Diff 15828.Jan 28 2020, 09:04

Fabien mentioned this in D5080: rpc: Make unloadwallet wait for complete wallet unload.Jan 28 2020, 09:33

nakihito accepted this revision.Jan 28 2020, 19:03

This revision is now accepted and ready to land.Jan 28 2020, 19:03

Closed by commit rABCdd757132e348: gui: Defer removeAndDeleteWallet when no modal widget is active (authored by João Barbosa <joao.paulo.barbosa@gmail.com>, committed by Fabien). · Explain WhyJan 28 2020, 20:47

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCdd757132e348: gui: Defer removeAndDeleteWallet when no modal widget is active.

Fabien added a commit: rSTAGINGdd757132e348: gui: Defer removeAndDeleteWallet when no modal widget is active.Apr 7 2020, 22:41

Revision Contents
Changeset List

Path

Size

src/

qt/

walletcontroller.cpp

20 lines

Diff 15854

View Options

src/qt/walletcontroller.cpp

gui: Defer removeAndDeleteWallet when no modal widget is activeClosedPublicActions