Fix ubsan failure in excessiveblock_tests
ClosedPublic
Actions

Authored by Fabien on Feb 3 2020, 18:12.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING1cdc1c46452f: Fix ubsan failure in excessiveblock_tests
rABC1cdc1c46452f: Fix ubsan failure in excessiveblock_tests

Summary

Introduced in D5136.

Test Plan

Run the UBSAN build.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 3 2020, 18:12

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2020, 18:12

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9247: Diff 15971.Feb 3 2020, 18:30

deadalnix accepted this revision.Feb 3 2020, 18:30

deadalnix added a subscriber: deadalnix.

deadalnix added inline comments.

src/test/excessiveblock_tests.cpp
60 ↗	(On Diff #15971)	Note that you could be using ::min() instead of ::max() and you wouldn't need to add 1.

This revision is now accepted and ready to land.Feb 3 2020, 18:30

Closed by commit rABC1cdc1c46452f: Fix ubsan failure in excessiveblock_tests (authored by Fabien). · Explain WhyFeb 3 2020, 18:40

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC1cdc1c46452f: Fix ubsan failure in excessiveblock_tests.

Fabien added a commit: rSTAGING1cdc1c46452f: Fix ubsan failure in excessiveblock_tests.Apr 7 2020, 22:47

Revision Contents
Changeset List

Path

Size

src/

test/

excessiveblock_tests.cpp

5 lines

Diff 15973

View Options

src/test/excessiveblock_tests.cpp

Fix ubsan failure in excessiveblock_testsClosedPublicActions