[CMAKE] Fix incompatibility between clang-tidy and -fstack-reuse
ClosedPublic
Actions

Authored by Fabien on Feb 4 2020, 09:31.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING6e1e1acb25d5: [CMAKE] Fix incompatibility between clang-tidy and -fstack-reuse
rABC6e1e1acb25d5: [CMAKE] Fix incompatibility between clang-tidy and -fstack-reuse

Summary

This flag is GCC only, but will be passed to the clang-tidy options
causing a diagnostic error. This diff prevents using the incompatible
flag when clang-tidy is enabled.
Since this is a hard error, it cannot be filtered out.

Test Plan

With GCC and clang-tidy enabled:

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 4 2020, 09:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 4 2020, 09:31

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9255: Diff 15990.Feb 4 2020, 09:37

markblundeberg accepted this revision.Feb 4 2020, 10:18

This revision is now accepted and ready to land.Feb 4 2020, 10:18

Closed by commit rABC6e1e1acb25d5: [CMAKE] Fix incompatibility between clang-tidy and -fstack-reuse (authored by Fabien). · Explain WhyFeb 4 2020, 11:00

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6e1e1acb25d5: [CMAKE] Fix incompatibility between clang-tidy and -fstack-reuse.

Fabien added a commit: rSTAGING6e1e1acb25d5: [CMAKE] Fix incompatibility between clang-tidy and -fstack-reuse.Apr 7 2020, 22:48

Revision Contents
Changeset List

Path

Size

src/

CMakeLists.txt

4 lines

Diff 15993

View Options

[CMAKE] Fix incompatibility between clang-tidy and -fstack-reuseClosedPublicActions