Page MenuHomePhabricator

[LINTER] Prevent using inline doxygen comments on their own line
ClosedPublic

Authored by Fabien on Fri, Feb 7, 15:29.

Details

Summary

This will prevent issues like D5180 to occur again.

Test Plan

Add a few doxygen inline comments in a source file such as:

///< A comment
//!< another comment
/**< yet another comment */
/*!< my last comment */

Run arc lint and check the linter offers to replace with the
non-inline equivalent.

arc lint --everything

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Fri, Feb 7, 15:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Feb 7, 15:29

Oh yeah good catch on those **< !

markblundeberg accepted this revision.Fri, Feb 7, 15:33
This revision is now accepted and ready to land.Fri, Feb 7, 15:33
Fabien updated this revision to Diff 16125.Fri, Feb 7, 16:12

Rebase.