Move lcov-filter.py to cmake/utils
ClosedPublic
Actions

Authored by Fabien on Feb 24 2020, 16:47.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING1397755858d1: Move lcov-filter.py to cmake/utils
rABC1397755858d1: Move lcov-filter.py to cmake/utils

Summary

Since coverage is a test related notion, this seems a better place.
The final goal is to include it with the secp256k1 library, and the
contrib directory is conflicting.

Test Plan

../configure --enable-lcov
make
make cov

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 24 2020, 16:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 24 2020, 16:47

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B9550: Diff 16475.Feb 24 2020, 17:03

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien added a child revision: D5321: [CMAKE] Add support for generating test coverage reports.Feb 24 2020, 21:42

It is test related, but this is not a test. IMO, you can move it somewhere down cmake/util or something like that, so that it gets exported to libsecp256k1.

That will make autotools to depend on a script from the cmake directory, but I don't think it's a big deal. Let's move it there.

Fabien retitled this revision from Move lcov-filter.py to test/coverage to Move lcov-filter.py to cmake/utils.Feb 28 2020, 13:04

Fabien edited the summary of this revision. (Show Details)