Page MenuHomePhabricator
Differential D5361

Spoof DISPLAY on headless build servers when generating manpages for bitcoin-qt
ClosedPublic
Actions

Authored by jasonbcox on Feb 28 2020, 02:21.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING4826fc6251ad: Spoof DISPLAY on headless build servers when generating manpages for bitcoin-qt
rABC4826fc6251ad: Spoof DISPLAY on headless build servers when generating manpages for bitcoin-qt
Summary

bitcoin-qt has a tightly coupled dependency on Qt resources being initialized before
help text is generated (see the code. it's related to translations). This is problematic for
generating the manpages because it needs to run bitcoin-qt --help. We can get around this
for now using xvfb to spoof a DISPLAY. A longer term solution would be to decouple Qt from
the help text, but a lot more thought needs to be put into if this is acceptable and if the
deviate from Core would be worth it.

Test Plan
COMMIT_TYPE=update-manpages ./automated-commits.sh  # fails without xvfb installed

sudo apt-get install xvfb
COMMIT_TYPE=update-manpages ./automated-commits.sh  # succeeds

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Feb 28 2020, 02:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 28 2020, 02:21
teamcity added a comment.Feb 28 2020, 05:31

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 28 2020, 05:54

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9622: Diff 16594.Feb 28 2020, 05:54
Fabien requested changes to this revision.Feb 28 2020, 11:13
Fabien added a subscriber: Fabien.

Please address the linter issue.

This revision now requires changes to proceed.Feb 28 2020, 11:13
jasonbcox updated this revision to Diff 16703.Mar 2 2020, 19:52

Fix linter issue

teamcity added a comment.Mar 2 2020, 19:58

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 2 2020, 20:20

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9688: Diff 16703.Mar 2 2020, 20:20
Fabien accepted this revision.Mar 3 2020, 08:17
This revision is now accepted and ready to land.Mar 3 2020, 08:17
Closed by commit rABC4826fc6251ad: Spoof DISPLAY on headless build servers when generating manpages for bitcoin-qt (authored by jasonbcox). · Explain WhyMar 3 2020, 16:26
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC4826fc6251ad: Spoof DISPLAY on headless build servers when generating manpages for bitcoin-qt.
jasonbcox added a commit: rSTAGING4826fc6251ad: Spoof DISPLAY on headless build servers when generating manpages for bitcoin-qt.Apr 7 2020, 23:12
jasonbcox mentioned this in D7677: Add missing dependency for install-manpages-html.Sep 29 2020, 23:28
jasonbcox mentioned this in rABCd076f001b708: Add missing dependency for install-manpages-html.Sep 29 2020, 23:44

Revision Contents
Changeset List

PathSize
contrib/
source-control-tools/
10 lines

Diff 16727

View Options

contrib/source-control-tools/automated-commits.sh

Loading...