Differential D5367

Make no-float policy explicit
ClosedPublic
Actions

Authored by deadalnix on Feb 28 2020, 13:49.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING91e49ef1b67d: Make no-float policy explicit
rABC91e49ef1b67d: Make no-float policy explicit

Summary

We don't want floating types for various reasons, e.g.,

Their representation and often their behavior is implementation-defined.
Many targets don't support them.

This is a backport of libsecp256k1 PR684

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Feb 28 2020, 13:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 28 2020, 13:49

Fabien accepted this revision.Feb 28 2020, 14:14

This revision is now accepted and ready to land.Feb 28 2020, 14:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9634: Diff 16611.Feb 28 2020, 14:52

Closed by commit rABC91e49ef1b67d: Make no-float policy explicit (authored by Tim Ruffing <crypto@timruffing.de>, committed by deadalnix). · Explain WhyFeb 28 2020, 15:40

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC91e49ef1b67d: Make no-float policy explicit.

deadalnix added a commit: rSTAGING91e49ef1b67d: Make no-float policy explicit.Apr 7 2020, 23:09

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

README.md

1 line

Diff 16617

View Options

Make no-float policy explicitClosedPublicActions