Page MenuHomePhabricator
Differential D5374

Preventing compiler optimizations in benchmarks without a memory fence
ClosedPublic
Actions

Authored by deadalnix on Feb 28 2020, 23:08.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGb61e2167a9a2: Preventing compiler optimizations in benchmarks without a memory fence
rABCb61e2167a9a2: Preventing compiler optimizations in benchmarks without a memory fence
Summary
  • Added accumulators and checks on benchmarks so they won't get optimized out
  • Modified bench_scalar_split so it won't get optimized out

This is a backport of libsecp256k1 PR678

Test Plan
ninja check-secp256k1
ninja bench-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Feb 28 2020, 23:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 28 2020, 23:08
teamcity added a comment.Feb 28 2020, 23:08

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix edited the test plan for this revision. (Show Details)Feb 28 2020, 23:08
deadalnix edited the summary of this revision. (Show Details)
teamcity added a comment.Feb 28 2020, 23:17

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9651: Diff 16638.Feb 28 2020, 23:17
Fabien accepted this revision.Mar 2 2020, 07:35
This revision is now accepted and ready to land.Mar 2 2020, 07:35
Closed by commit rABCb61e2167a9a2: Preventing compiler optimizations in benchmarks without a memory fence (authored by Elichai Turkel <elichai.turkel@gmail.com>, committed by deadalnix). · Explain WhyMar 2 2020, 15:32
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCb61e2167a9a2: Preventing compiler optimizations in benchmarks without a memory fence.
deadalnix added a commit: rSTAGINGb61e2167a9a2: Preventing compiler optimizations in benchmarks without a memory fence.Apr 7 2020, 23:11

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
54 lines

Diff 16692

View Options

src/secp256k1/src/bench_internal.c

Loading...