Page MenuHomePhabricator
Differential D5382

[backport] qt: Replace obsolete functions of QSslSocket #16708
ClosedPublic
Actions

Authored by majcosta on Feb 29 2020, 15:08.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING8d97e27d5447: [backport] qt: Replace obsolete functions of QSslSocket #16708
rABC8d97e27d5447: [backport] qt: Replace obsolete functions of QSslSocket #16708
Summary

2e1455c4a100170c322165af3ecbbcd3004b2f9d Replace obsolete functions of QSslSocket (Hennadii Stepanov)

Pull request description:

The [QSslSocket::setDefaultCaCertificates()](https://doc.qt.io/qt-5/qsslsocket-obsolete.html#setDefaultCaCertificates) and [QSslSocket::systemCaCertificates()](https://doc.qt.io/qt-5/qsslsocket-obsolete.html#systemCaCertificates) member functions are obsolete since Qt 5.12.

This PR replaces them, does not change behavior and keeps compatibility with Qt 5.5.1.

This is a backport of Core PR16708

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

majcosta created this revision.Feb 29 2020, 15:08
Owners added a reviewer: Restricted Owners Package.Feb 29 2020, 15:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 29 2020, 15:08
teamcity edited the summary of this revision. (Show Details)Feb 29 2020, 15:08

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 29 2020, 15:08

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 29 2020, 15:20

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9663: Diff 16660.Feb 29 2020, 15:20
deadalnix accepted this revision.Feb 29 2020, 16:01
This revision is now accepted and ready to land.Feb 29 2020, 16:01
Closed by commit rABC8d97e27d5447: [backport] qt: Replace obsolete functions of QSslSocket #16708 (authored by Wladimir J. van der Laan <laanwj@protonmail.com>, committed by majcosta). · Explain WhyFeb 29 2020, 16:10
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC8d97e27d5447: [backport] qt: Replace obsolete functions of QSslSocket #16708.
majcosta added a commit: rSTAGING8d97e27d5447: [backport] qt: Replace obsolete functions of QSslSocket #16708.Apr 7 2020, 23:10

Revision Contents
Changeset List

PathSize
src/
qt/
6 lines

Diff 16661

View Options

src/qt/paymentserver.cpp

Loading...