revert to deprecated protobuf ByteSize() due to compatibility
ClosedPublic
Actions

Authored by majcosta on Mar 1 2020, 15:48.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGff651ab013da: revert to deprecated protobuf ByteSize() due to compatibility
rABCff651ab013da: revert to deprecated protobuf ByteSize() due to compatibility

Summary

the change in D5386 breaks compatibility with protobuf 2.6.1, which is what we target, the newer ByteSizeLong() function being introduced in protobuf 3.1

this diff reverts that change

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

majcosta created this revision.Mar 1 2020, 15:48

Owners added a reviewer: Restricted Owners Package.Mar 1 2020, 15:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 1 2020, 15:48

Build Bitcoin-ABC / Diffs / Diff Testing started.

majcosta edited the summary of this revision. (Show Details)Mar 1 2020, 15:49

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9674: Diff 16674.Mar 1 2020, 15:58

deadalnix accepted this revision.Mar 1 2020, 22:42

This revision is now accepted and ready to land.Mar 1 2020, 22:42

Closed by commit rABCff651ab013da: revert to deprecated protobuf ByteSize() due to compatibility (authored by majcosta). · Explain WhyMar 1 2020, 22:44

This revision was automatically updated to reflect the committed changes.

majcosta added a commit: rABCff651ab013da: revert to deprecated protobuf ByteSize() due to compatibility.

majcosta added a commit: rSTAGINGff651ab013da: revert to deprecated protobuf ByteSize() due to compatibility.Apr 7 2020, 23:10

Revision Contents
Changeset List

Path

Size

src/

qt/

paymentserver.cpp

7 lines

Diff 16675

View Options

revert to deprecated protobuf ByteSize() due to compatibilityClosedPublicActions