Page MenuHomePhabricator
Differential D5432

Merge #13264: [qt] Satoshi unit
ClosedPublic
Actions

Authored by nakihito on Mar 4 2020, 21:20.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING7ff1309f12ed: Merge #13264: [qt] Satoshi unit
rABC7ff1309f12ed: Merge #13264: [qt] Satoshi unit
Summary

c722f00a7 [qt] Added satoshi unit "Satoshi (sat)" will be displayed in dropdowns and status bars. "sat" will be used when appended to numbers. (GreatSock)
4ddbcbf8c [qt] BitcoinUnits::format with zero decimals Formatting with zero decimals will now result in 123 instead of 123.0 (GreatSock)

Pull request description:

This adds satoshi as an additional amount unit for the GUI.

Tree-SHA512: c166c96c9a434b6ac700e1628e54f2dbb132c5232d949c0b464f61276a91d56f9bab4a62d50780535f1d34eaac6484f693a1e0611cd7c9d1ed5ebee066c0dd08

Backport of Core PR13264

Test Plan
ninja
./bitcoin-qt

Settings -> Options -> Display -> change units to Satoshi
Verify change in units in display.

pr13264.png (528×841 px, 39 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Mar 4 2020, 21:20
Owners added a reviewer: Restricted Owners Package.Mar 4 2020, 21:20
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 4 2020, 21:20
nakihito planned changes to this revision.Mar 4 2020, 21:20
teamcity edited the summary of this revision. (Show Details)Mar 4 2020, 21:20

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 4 2020, 21:20

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito requested review of this revision.Mar 4 2020, 21:23
nakihito edited the test plan for this revision. (Show Details)
teamcity added a comment.Mar 4 2020, 21:30

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9733: Diff 16775.Mar 4 2020, 21:30
Fabien accepted this revision.Mar 5 2020, 07:58
This revision is now accepted and ready to land.Mar 5 2020, 07:58
Closed by commit rABC7ff1309f12ed: Merge #13264: [qt] Satoshi unit (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by nakihito). · Explain WhyMar 5 2020, 19:29
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC7ff1309f12ed: Merge #13264: [qt] Satoshi unit.
nakihito added a commit: rSTAGING7ff1309f12ed: Merge #13264: [qt] Satoshi unit.Apr 7 2020, 23:14

Revision Contents
Changeset List

PathSize
src/
qt/
2 lines
30 lines

Diff 16779

View Options

src/qt/bitcoinunits.h

Loading...
View Options

src/qt/bitcoinunits.cpp

Loading...