Page MenuHomePhabricator

[CMAKE] Improve FindSHLWAPI
ClosedPublic

Authored by Fabien on Mar 9 2020, 13:53.

Details

Summary

This makes the FindSHLWAPI consistent with the other find modules.
There are few benefits right now because the imported target cannot be
used due to cmake bugs
(https://gitlab.kitware.com/cmake/cmake/issues/16291,
https://gitlab.kitware.com/cmake/cmake/issues/19095) but makes it future
proof when cmake > 3.14.1 get enforced.

Test Plan
ninja check

Run the Gitian builds.

I also tested using the imported target with cmake 3.14.1.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Mar 11 2020, 03:08
This revision was automatically updated to reflect the committed changes.