Page MenuHomePhabricator
Differential D5464

Use const in COutPoint class
ClosedPublic
Actions

Authored by Fabien on Mar 11 2020, 22:26.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING4b1e7c09100b: Use const in COutPoint class
rABC4b1e7c09100b: Use const in COutPoint class
Summary
Refactoring:

    all cases of using (uint32_t) -1 in COutPoint class are replaced
with const;
    also all remaining instances of (UNSIGNED)-1 transformed to
std::numeric_limits<UNSIGNED>::max() (by @practicalswift).

Backport of core PR14838.

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 11 2020, 22:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 11 2020, 22:26
teamcity edited the summary of this revision. (Show Details)Mar 11 2020, 22:27

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 11 2020, 22:27

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 11 2020, 22:39

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9787: Diff 16884.Mar 11 2020, 22:39
deadalnix accepted this revision.Mar 12 2020, 15:20
This revision is now accepted and ready to land.Mar 12 2020, 15:20
Closed by commit rABC4b1e7c09100b: Use const in COutPoint class (authored by Hennadii Stepanov <32963518+hebasto@users.noreply.github.com>, committed by Fabien). · Explain WhyMar 12 2020, 15:27
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC4b1e7c09100b: Use const in COutPoint class.
Fabien added a commit: rSTAGING4b1e7c09100b: Use const in COutPoint class.Apr 7 2020, 23:19

Revision Contents
Changeset List

PathSize
src/
primitives/
6 lines
5 lines
test/
2 lines

Diff 16896

View Options

src/primitives/transaction.h

Loading...
View Options

src/streams.h

Loading...
View Options

src/test/serialize_tests.cpp

Loading...