Page MenuHomePhabricator

wallet: Avoid leaking nLockTime fingerprint when anti-fee-sniping
ClosedPublic

Authored by Fabien on Wed, Mar 25, 12:15.

Details

Summary
The wallet sets the locktime to the current height of our active chain.
This is fine, as long as our node is connected to other nodes. However,
when we fall back and get stuck at a particular height (e.g. taking the
wallet offline), the same (potentially unique) locktime is used for all
transactions. This makes it easier for passive observers to cluster
transactions by wallet.

Backport of core PR15039.

Test Plan
ninja check check-functional-extended

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Wed, Mar 25, 12:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Mar 25, 12:15
teamcity edited the summary of this revision. (Show Details)Wed, Mar 25, 12:15

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

deadalnix accepted this revision.Wed, Mar 25, 18:38
This revision is now accepted and ready to land.Wed, Mar 25, 18:38