Page MenuHomePhabricator
Differential D5582

Merge #14813: qa: Add wallet_encryption error tests
ClosedPublic
Actions

Authored by nakihito on Mar 26 2020, 21:58.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGdee5e745ae59: Merge #14813: qa: Add wallet_encryption error tests
rABCdee5e745ae59: Merge #14813: qa: Add wallet_encryption error tests
Summary

fa739d4bd7 qa: Add wallet_encryption error tests (MarcoFalke)

Pull request description:

The errors for empty passphrases are the help text of the RPC call, which is not very specific. Replace that with proper RPC errors and test them.

Tree-SHA512: 3137e0f8f2e42a1f8ab1eeb57c99052557725f6f85139ff48c24acc8f3cf4087802de5216f3ce97375b291d21bddb7cd1379a6f280166136a306a0c9663bbd42

Backport of Core PR14813

Test Plan
ninja
test_runner.py wallet_encryption

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Mar 26 2020, 21:58
Owners added a reviewer: Restricted Owners Package.Mar 26 2020, 21:58
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 26 2020, 21:58
teamcity edited the summary of this revision. (Show Details)Mar 26 2020, 21:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 26 2020, 21:59

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 26 2020, 22:09

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9998: Diff 17224.Mar 26 2020, 22:09
deadalnix accepted this revision.Mar 26 2020, 23:18
This revision is now accepted and ready to land.Mar 26 2020, 23:18
Closed by commit rABCdee5e745ae59: Merge #14813: qa: Add wallet_encryption error tests (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyMar 26 2020, 23:38
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABCdee5e745ae59: Merge #14813: qa: Add wallet_encryption error tests.
nakihito added a commit: rSTAGINGdee5e745ae59: Merge #14813: qa: Add wallet_encryption error tests.Apr 7 2020, 23:29

Revision Contents
Changeset List

PathSize
src/
wallet/
45 lines
test/
functional/
19 lines

Diff 17228

View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/wallet_encryption.py

Loading...